Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40925 )
Change subject: Documentation/mb/ocp/tiogapass: Add documentation ......................................................................
Patch Set 3:
(8 comments)
https://review.coreboot.org/c/coreboot/+/40925/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40925/3//COMMIT_MSG@7 PS3, Line 7: Documentation Doc
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... File Documentation/mainboard/ocp/tiogapass.md:
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 26: priviledge privilege
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 30: Linuxboot binary You can compile that from source. It's not a blob.
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 38: not verified Huh?
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 42: OpenBMC If you are using the BMC to flash coreboot, that is considered internal programming. External programming consists of connecting something like a Dediprog SF600 and flashing with that.
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 85: SoC Why not call it CPU or processor? Intel uses "Processor":
https://ark.intel.com/content/www/us/en/ark/products/series/125191/intel-xeo...
https://review.coreboot.org/c/coreboot/+/40925/3/Documentation/mainboard/ocp... PS3, Line 87: 2500 AST2500
https://review.coreboot.org/c/coreboot/+/40925/1/MAINTAINERS File MAINTAINERS:
https://review.coreboot.org/c/coreboot/+/40925/1/MAINTAINERS@365 PS1, Line 365: OCP TIOGAPASS MAINBOARD
Make a new patch for this
Done