Attention is currently required from: Hung-Te Lin, Jarried Lin.
Nancy Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85950?usp=email )
Change subject: soc/mediatek/mt8196: Add display driver
......................................................................
Patch Set 2:
(1 comment)
File src/soc/mediatek/mt8196/ddp.c:
https://review.coreboot.org/c/coreboot/+/85950/comment/e867056b_4dee475b?usp... :
PS2, Line 308:
OK, I will fix it
After check HW spec, some engines's w/h is 16 bits, some are 13 bits. So Can I check only width <= 0xFFFF && height <= 0xFFFF
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85950?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I006911e83d940c1eec7135a6a0c36fbfa2aad466
Gerrit-Change-Number: 85950
Gerrit-PatchSet: 2
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nancy Lin
nancy.lin@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Wed, 15 Jan 2025 06:56:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nancy Lin
nancy.lin@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com