[coreboot-gerrit] [S] Change in coreboot[master]: soc/amd/common/block/cpu/update_microcode: use raw MSR data

[Paul Fagerburg (Code Review)]

Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73636 )

Change subject: soc/amd/common/block/cpu/update_microcode: use raw MSR data
......................................................................

soc/amd/common/block/cpu/update_microcode: use raw MSR data

Since mst_t is a union of the struct containing the lower and higher 32
bits and the raw 64 bit value, the address of the microcode update can
be directly written to the raw value instead of needing to split it into
the lower and higher 32 bits and assigning those separately.

Signed-off-by: Felix Held 
Change-Id: I51c84164e81477040a4b7810552d3d65c0e3656b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73636
Tested-by: build bot (Jenkins) 
Reviewed-by: Martin Roth 
---
M src/soc/amd/common/block/cpu/update_microcode.c
1 file changed, 19 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved

diff --git a/src/soc/amd/common/block/cpu/update_microcode.c b/src/soc/amd/common/block/cpu/update_microcode.c
index cfffbc0..0edb9d2 100644
--- a/src/soc/amd/common/block/cpu/update_microcode.c
+++ b/src/soc/amd/common/block/cpu/update_microcode.c
@@ -37,8 +37,7 @@
    uint32_t new_patch_id;
    msr_t msr;

-	msr.hi = (uint64_t)(uintptr_t)m >> 32;
-	msr.lo = (uintptr_t)m & 0xffffffff;
+	msr.raw = (uintptr_t)m;

wrmsr(MSR_PATCH_LOADER, msr);