Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36385 )
Change subject: ec/lenovo/h8: Add a config to indicate whether dock init is needed
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36385/2/src/ec/lenovo/h8/h8.c
File src/ec/lenovo/h8/h8.c:
https://review.coreboot.org/c/coreboot/+/36385/2/src/ec/lenovo/h8/h8.c@357
PS2, Line 357: #if CONFIG(H8_DOCK_INIT)
I would rather keep this scheme, as I have no condition to test all boards that use h8_mainboard_ini […]
The H8_DOCK_INIT could be treated as transitional, eliminating empty h8_mainboard_init_dock() declarations first, and migrate to your scheme board by board, just as C_ENVIRONMENT_BOOTBLOCK.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36385
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5737406d1f6cb6e91b2e2fa349a206a3dba988d1
Gerrit-Change-Number: 36385
Gerrit-PatchSet: 2
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 28 Oct 2019 02:29:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Bill XIE
persmule@hardenedlinux.org
Gerrit-MessageType: comment