Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35593 )
Change subject: soc/cavium/common/Makefile: Change STACK_SIZE value to decimal
......................................................................
Patch Set 5:
(1 comment)
Uh my bad.
https://review.coreboot.org/c/coreboot/+/35593/4/src/soc/cavium/common/Makef...
File src/soc/cavium/common/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35593/4/src/soc/cavium/common/Makef...
PS4, Line 20: $(CONFIG_STACK_SIZE)
does $(($(CONFIG_STACK_SIZE))) not work?
The following should work.
CFLAGS_arm64 += -Wstack-usage=$(shell printf "%d" $(CONFIG_STACK_SIZE))
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35593
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73606d347194af5de5882a3387a4a5db17f9d94b
Gerrit-Change-Number: 35593
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 03 Oct 2019 07:51:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment