Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48577 )
Change subject: soc/intel/braswell: Clean up devicetree settings ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/48577/2/src/soc/intel/braswell/roms... File src/soc/intel/braswell/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/48577/2/src/soc/intel/braswell/roms... PS2, Line 117: upd->PcdMrcInitMmioSize = 0x800; could be dropped, fsp defaults to 0x800
https://review.coreboot.org/c/coreboot/+/48577/2/src/soc/intel/braswell/roms... PS2, Line 121: upd->PcdApertureSize = 2; : upd->PcdGttSize = 1; : upd->PcdLegacySegDecode = 0; : same here, these are fsp defaults already