Attention is currently required from: David Wu, Ian Feng, Kapil Porwal, Nick Vaccaro, Qinghong Zeng, Reka Norman, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80158?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brya: Correct EC-is-trusted logic
......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80158/comment/defaef16_04cfee6d :
PS2, Line 2: zengqinghong
Please use the official(?) spelling of your name.
git config --global user.name "Qinghong Zeng"
git commit --amend --author="Qinghong Zeng zengqinghong@huaqin.corp-partner.google.com" -s
https://review.coreboot.org/c/coreboot/+/80158/comment/4e6588ff_6a169715 :
PS2, Line 7: Correct EC-is-trusted logic
:
Please be more specific, and also mention Ti50.
https://review.coreboot.org/c/coreboot/+/80158/comment/3204712c_c33041e3 :
PS2, Line 10: trusted.
Should fit on the line above.
https://review.coreboot.org/c/coreboot/+/80158/comment/aceb0358_1a985486 :
PS2, Line 10: where
which?
https://review.coreboot.org/c/coreboot/+/80158/comment/1227b09d_6549e0a1 :
PS2, Line 24: zengqinghong
Ditto.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80158?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I308f8b36411030911c4421d80827fc49ff325a1b
Gerrit-Change-Number: 80158
Gerrit-PatchSet: 2
Gerrit-Owner: Qinghong Zeng
zengqinghong@huaqin.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Qinghong Zeng
zengqinghong@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 29 Jan 2024 08:17:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment