Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45469 )
Change subject: apollolake boards: Enable CSE in devicetree
......................................................................
Patch Set 4:
Patch Set 4: Code-Review-1
I'm not sure if we really want to enable CSE/ME/... by default
To answer your question, please look at this code https://github.com/coreboot/coreboot/blob/master/src/soc/intel/apollolake/ch...
Like every platform, coreboot will ensure to make CSE bus function disable that means prior to boot to OS (after EOP is done), CSE will not visible on bus irrespective of being listen in devicetree.cb. hence your concern is already been taken care that CSE shouldn't be default enable.
Hope this help to clarify things ?
if yes, can you please reconsider your vote?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45469
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97d221ae52b4b03ecd859d708847ad77fe4bf465
Gerrit-Change-Number: 45469
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Elyes HAOUAS
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Comment-Date: Fri, 18 Sep 2020 02:56:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment