[coreboot-gerrit] [M] Change in coreboot[main]: soc/mediatek/mt8196: Initialize MCUPM

[Jarried Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu, agogo.

Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85888?usp=email )

Change subject: soc/mediatek/mt8196: Initialize MCUPM
......................................................................

Patch Set 5:

(5 comments)

File src/soc/mediatek/mt8196/include/soc/mcupm_plat.h:

https://review.coreboot.org/c/coreboot/+/85888/comment/4c412f71_380ca891?usp... :
PS4, Line 38:  /* 0x1C004000 */
> Remove comment

Done

https://review.coreboot.org/c/coreboot/+/85888/comment/61f85031_1867af51?usp... :
PS4, Line 40: b
> B

Done

https://review.coreboot.org/c/coreboot/+/85888/comment/3f59f6c9_619f640e?usp... :
PS4, Line 82: 0x00000004
> 0x4

Done

https://review.coreboot.org/c/coreboot/+/85888/comment/a86f52dc_51e9e865?usp... :
PS4, Line 84: 0x00000014
> 0x14

Done

File src/soc/mediatek/mt8196/mcupm.c:

https://review.coreboot.org/c/coreboot/+/85888/comment/90a312b5_63e69237?usp... :
PS4, Line 40: 		       "[EB_SPMC] Polling ACK timeout, %#x\n",
> move to previous line

Done