Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47893 )
Change subject: mb/ocp/deltalake: Update SMBIOS type 8 information
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/47893/1/src/mainboard/ocp/deltalake...
File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/47893/1/src/mainboard/ocp/deltalake...
PS1, Line 158: SMBIOS
nit: lowercase
Ack
https://review.coreboot.org/c/coreboot/+/47893/1/src/mainboard/ocp/deltalake...
PS1, Line 167: {
: "JCN18 - CPU MIPI60",
: CONN_OTHER,
: "",
: CONN_NONE,
: TYPE_OTHER_PORT
: },
You can remove the comment above if you write the struct initializers as follows: […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47893
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I880bb9a5a41077172423f78b56c19aadd93e001f
Gerrit-Change-Number: 47893
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Nov 2020 18:23:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment