Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44262 )
Change subject: soc/intel/tigerlake: move mainboard_silicon_init_params
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44262/1/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/44262/1/src/soc/intel/tigerlake/fsp...
PS1, Line 110: mainboard_silicon_init_params(params);
Shouldn't this be done as the very first thing in this function? i.e. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44262
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idfce528efa7806e292071e092fb129b53a94a145
Gerrit-Change-Number: 44262
Gerrit-PatchSet: 2
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 06 Aug 2020 08:11:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment