Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38241 )
Change subject: asus/am1i-a: fix the blue "USB 3.0" ports for OHCI/EHCI "USB 2.0" mode
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38241/1/src/mainboard/asus/am1i-a/a...
File src/mainboard/asus/am1i-a/acpi/routing.asl:
https://review.coreboot.org/c/coreboot/+/38241/1/src/mainboard/asus/am1i-a/a...
PS1, Line 54: 1
This is identical to the code above for USB at dev 12 and 13.
The second field in the package describes the pin number, not the function number of the PCI device it describes the interrupt for.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38241
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50a773eeab890627abc963e0a61f781d1cea3259
Gerrit-Change-Number: 38241
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Elisenda
lists@e4l.es
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 Jan 2020 15:43:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Mike Banon
mikebdp2@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment