Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38399 )
Change subject: mb/google/hatch/variants/mushu: modify PCIe ports setting
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38399/5/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/mushu/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/38399/5/src/mainboard/google/hatch/...
PS5, Line 75: # PCIe port 3 reserve for GPU REFCLK
: register "PcieRpEnable[2]" = "1"
: register "PcieRpLtrEnable[2]" = "
PCIE#3 seems to be connected to test points?
How is this connected to the GPU REFCLK?
https://review.coreboot.org/c/coreboot/+/38399/5/src/mainboard/google/hatch/...
PS5, Line 80: 2
This should be 4 according to my discussion with shanthi.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38399
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea3292be7d8029c35847118228bbb773418632a1
Gerrit-Change-Number: 38399
Gerrit-PatchSet: 5
Gerrit-Owner: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Jan 2020 22:16:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment