Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35323 )
Change subject: soc/intel/cnl: Remove unnecessary FSP UPD “PchPwrOptEnable” usage
......................................................................
Patch Set 1:
(1 comment)
So, this is not required anymore for S0
https://review.coreboot.org/c/coreboot/+/35323/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35323/1//COMMIT_MSG@7
PS1, Line 7: PchPwrOptEnable
So, this is not required anymore for S0ix. This change seems to indicate that it was necessary for running S0ix on sarien/arcada: https://review.coreboot.org/c/coreboot/+/30212/
What changed? How did you identify that this UPD should not be set?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35323
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6da2a088fb697e57d12008fa18bd1764b3da7765
Gerrit-Change-Number: 35323
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 11 Sep 2019 07:13:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment