[coreboot-gerrit] Change in ...coreboot[master]: soc/amd/common: Identify AGESA call pattern

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31488 )

Change subject: soc/amd/common: Identify AGESA call pattern
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/31488/5/src/soc/amd/common/block/pi/agesawra... 
File src/soc/amd/common/block/pi/agesawrapper.c:

https://review.coreboot.org/#/c/31488/5/src/soc/amd/common/block/pi/agesawra... 
PS5, Line 68: AGESA_STATUS
> Why return status if it won't be used outside create struct?

Some consistency with src/drivers.

With the eventlog feature in PI, it's not the best place to have die() inside this function. We should let this return, dump the log in case of !SUCCESS and then decide if this is recoverable or not.