Attention is currently required from: Angel Pons.
Václav Straka has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email )
Change subject: mb/hp: Add Pro 3400 ......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85825/comment/d139cc43_1fa6f77e?usp... : PS1, Line 11: As a side effect fixed 3500's USB. (broken since 81878)
I'm basing this off https://doc.coreboot.org/contributing/gerrit_guidelines. […]
Okay, I'll create a new change and rebase this one on top of that.
File src/mainboard/hp/pro_3x00_series/Kconfig:
https://review.coreboot.org/c/coreboot/+/85825/comment/b0e0ff76_c05b4160?usp... : PS1, Line 47: default "src/mainboard/$(MAINBOARDDIR)/variants/$(CONFIG_VARIANT_DIR)/data.vbt"
That's true. I assumed it isn't and just copied it from hp/snb_ivb_desktops. I will remove it.
Done
File src/mainboard/hp/pro_3x00_series/cmos.default:
https://review.coreboot.org/c/coreboot/+/85825/comment/f865e6cb_e337f536?usp... : PS1, Line 6: nmi=Enable
Acknowledged
Done
File src/mainboard/hp/pro_3x00_series/cmos.layout:
https://review.coreboot.org/c/coreboot/+/85825/comment/208ae70a_27b0479e?usp... : PS1, Line 26: # SandyBridge MRC Scrambler Seed values : 896 32 r 0 mrc_scrambler_seed : 928 32 r 0 mrc_scrambler_seed_s3 : 960 16 r 0 mrc_scrambler_seed_chk
Acknowledged
Done
File src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85825/comment/6609a9a3_f1f1a601?usp... : PS1, Line 24: device ref mei1 off end
I copied this from autoport's output, i probably had the FDO jumper on at that time without realizin […]
Done