Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32662 )
Change subject: soc/amd/stoneyrige: Add ALink-AHB Bridge to iomap.h
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32662/1/src/soc/amd/stoneyridge/include/soc/...
File src/soc/amd/stoneyridge/include/soc/iomap.h:
https://review.coreboot.org/#/c/32662/1/src/soc/amd/stoneyridge/include/soc/...
PS1, Line 31: #define I2C_BASE_ADDRESS 0xfedc2000
: #define I2C_DEVICE_SIZE 0x00001000
: #define I2C_DEVICE_COUNT 4
:
:
I agree with alignment, but it does not belong to the commit (not mentioned on commit message). […]
Some amount of leniency is afforded to adjacent inconsequential changes, but fine... I intend to modify it later anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32662
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0b99de78d8c5948e2e5f2aa50dfc2efc1bd1ba1
Gerrit-Change-Number: 32662
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 May 2019 15:18:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment