16 Jan
2019
16 Jan
'19
12:35 a.m.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30913 )
Change subject: mainboard/intel: Update mainboard UART Kconfig ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30913/2/src/mainboard/intel/coffeelake_rvp/K... File src/mainboard/intel/coffeelake_rvp/Kconfig:
https://review.coreboot.org/#/c/30913/2/src/mainboard/intel/coffeelake_rvp/K... PS2, Line 21: INTEL_LPSS_UART_FOR_CONSOLE
Line #10 is enable LPSS UART for ony for WHLRVP without impacting other Coffeelake varients. […]
I mean removing condition in line #10 is enough.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30913
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0381a6616f03c74c98f837e3c008459fefd4818c
Gerrit-Change-Number: 30913
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: PraveenX Hodagatta Pranesh praveenx.hodagatta.pranesh@intel.com
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Comment-Date: Wed, 16 Jan 2019 00:35:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: PraveenX Hodagatta Pranesh praveenx.hodagatta.pranesh@intel.com
Comment-In-Reply-To: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-MessageType: comment