Attention is currently required from: Felix Singer, Michał Żygowski, Stefan Reinauer, Michael Niewöhner.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63374 )
Change subject: util/inteltool: Add support for Alder Lake chips detection and GPIOs
......................................................................
Patch Set 9:
(4 comments)
File util/inteltool/gpio_names/alderlake_h.h:
https://review.coreboot.org/c/coreboot/+/63374/comment/dbf38b44_4b480256
PS8, Line 437: &alderlake_pch_h_group_j,
In the coreboot tree we add vgpios, for completeness we should add them here as well
Done
https://review.coreboot.org/c/coreboot/+/63374/comment/43dd351d_fff4cda0
PS8, Line 473: &alderlake_pch_h_group_c,
vpgio3 missing
Done
https://review.coreboot.org/c/coreboot/+/63374/comment/84c9baf7_812eea12
PS8, Line 498: &alderlake_pch_h_group_d,
jtag and cpu gorups missing
Done
File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/63374/comment/03fbb77c_74aaa252
PS8, Line 436: #define PCI_DEVICE_ID_INTEL_ADL_S_GT1 0x4680
Added remaining device IDs for ADL-S
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63374
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0001395517e1e7977b0f808d5d74cf85c52298d6
Gerrit-Change-Number: 63374
Gerrit-PatchSet: 9
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Mon, 11 Apr 2022 13:40:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-MessageType: comment