Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34285 )
Change subject: soc/intel: Fix regression with hidden PCI devices
......................................................................
Patch Set 5:
Patch Set 5:
- On SKL, KBL: Config write requests work on only one register, 32 bits, to unhide it.
Sorry, I remembered this wrong. All config writes should work.
That is right. Writes should work.
- Unhiding only works as long as the P2SB uses BOOT_SAI.
I'm not sure about this any more, either. But at least there
is something related that makes it impossible to unhide.
I think you are referring to endpoint mask locking: https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/common/bloc...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34285
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5eab3e7f1993b686103eaa257aacda379dc259fa
Gerrit-Change-Number: 34285
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Vanny E
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 13 Jul 2019 16:56:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment