Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33755 )
Change subject: soc/amd/picasso: Remove all AGESA references
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/33755/4/src/soc/amd/picasso/include...
File src/soc/amd/picasso/include/soc/northbridge.h:
https://review.coreboot.org/c/coreboot/+/33755/4/src/soc/amd/picasso/include...
PS4, Line 113: void amd_initcpuio(void);
This looked out of place being added here, but the initial prototype was in one of the AGESA headers that is being removed, so it needed to be added.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33755
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea1a41941a0ba364a6abaaf31cc8e1145db4a236
Gerrit-Change-Number: 33755
Gerrit-PatchSet: 4
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 05 Jul 2019 17:25:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment