[coreboot-gerrit] Change in coreboot[master]: arch/x86/postcar: Set up postcar MTRR in C code

[Arthur Heymans (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Subrata Banik, Marshall Dawson, Kyösti Mälkki, Aaron Durbin, Felix Held.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54299 )

Change subject: arch/x86/postcar: Set up postcar MTRR in C code
......................................................................

Patch Set 11:

(3 comments)

File src/arch/x86/postcar.c:

https://review.coreboot.org/c/coreboot/+/54299/comment/a3d2e434_78f7d4ee 
PS11, Line 3: #include <cpu/x86/msr.h>
> u can put this in order, rest looks good.

Done

File src/cpu/x86/mtrr/earlymtrr.c:

https://review.coreboot.org/c/coreboot/+/54299/comment/83453310_ada2cb15 
PS11, Line 126: 	for (int i = 0; i < ctx->max_var_mtrrs; i++) {
              : 		wrmsr(MTRR_PHYS_BASE(i), zero);
              : 		wrmsr(MTRR_PHYS_MASK(i), zero);
              : 	}
> can't u use clear_all_var_mtrr() here ?

Done

https://review.coreboot.org/c/coreboot/+/54299/comment/b6eebce7_22e0ca31 
PS11, Line 131: 		wrmsr(MTRR_PHYS_BASE(i), ctx->mtrr[i].base);
              : 		wrmsr(MTRR_PHYS_MASK(i), ctx->mtrr[i].mask);
> set_var_mtrr() may be ?

That would be an option but then I have to rewrite the postcar setup to use size instead of mask. Also romstage already made sure that base and mask are correct so there is no need for the checking in set_var_mtrr. I'd think this is ok.