Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31329 )
Change subject: vboot: copy data structures to CBMEM for downstream use ......................................................................
Patch Set 11: Code-Review+1
(4 comments)
https://review.coreboot.org/#/c/31329/10/src/security/vboot/common.c File src/security/vboot/common.c:
https://review.coreboot.org/#/c/31329/10/src/security/vboot/common.c@78 PS10, Line 78: size_t work_size;
nit: this variable is a bit pointless now
Done
https://review.coreboot.org/#/c/31329/10/src/security/vboot/common.c@98 PS10, Line 98: end
nit: maybe it's just me but "end" sounds weird. […]
Done
https://review.coreboot.org/#/c/31329/10/src/security/vboot/common.c@162 PS10, Line 162: cbmem_size);
I think you need to adjust buffer_size as well? In fact, I'm not sure if having both a buffer_size a […]
Good point... Let's just do the "shrinking" strategy as you suggested. No need for buffer_used.
https://review.coreboot.org/#/c/31329/10/src/security/vboot/vboot_loader.c File src/security/vboot/vboot_loader.c:
https://review.coreboot.org/#/c/31329/10/src/security/vboot/vboot_loader.c@1... PS10, Line 132: if (ENV_ROMSTAGE && CONFIG(VBOOT_STARTS_IN_ROMSTAGE)) {
nit: could lose the braces now
Done