Patch set 11:Code-Review +1
4 comments:
File src/security/vboot/common.c:
Patch Set #10, Line 78: size_t work_size;
nit: this variable is a bit pointless now
Done
nit: maybe it's just me but "end" sounds weird. […]
Done
Patch Set #10, Line 162: cbmem_size);
I think you need to adjust buffer_size as well? In fact, I'm not sure if having both a buffer_size a […]
Good point... Let's just do the "shrinking" strategy as you suggested. No need for buffer_used.
File src/security/vboot/vboot_loader.c:
Patch Set #10, Line 132: if (ENV_ROMSTAGE && CONFIG(VBOOT_STARTS_IN_ROMSTAGE)) {
nit: could lose the braces now
Done
To view, visit change 31329. To unsubscribe, or for help writing mail filters, visit settings.