build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32421 )
Change subject: nb/amd/pi: support for boards without BINARYPI_LEGACY_WRAPPER ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/#/c/32421/1/src/northbridge/amd/pi/00630F01/nort... File src/northbridge/amd/pi/00630F01/northbridge.c:
https://review.coreboot.org/#/c/32421/1/src/northbridge/amd/pi/00630F01/nort... PS1, Line 1015: AmdGetValue(IN CONST AGESA_FIELD_NAME name, IN OUT VOID **value, IN UINT32 size) need consistent spacing around '*' (ctx:WxO)
https://review.coreboot.org/#/c/32421/1/src/northbridge/amd/pi/00630F01/nort... PS1, Line 1029: status = module_dispatch(AMD_GET_VALUE, (AMD_CONFIG_PARAMS*) &Params); "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/32421/1/src/northbridge/amd/pi/00660F01/nort... File src/northbridge/amd/pi/00660F01/northbridge.c:
https://review.coreboot.org/#/c/32421/1/src/northbridge/amd/pi/00660F01/nort... PS1, Line 1000: AmdGetValue(IN CONST AGESA_FIELD_NAME name, IN OUT VOID **value, IN UINT32 size) need consistent spacing around '*' (ctx:WxO)
https://review.coreboot.org/#/c/32421/1/src/northbridge/amd/pi/00660F01/nort... PS1, Line 1014: status = module_dispatch(AMD_GET_VALUE, (AMD_CONFIG_PARAMS*) &Params); "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/32421/1/src/northbridge/amd/pi/00730F01/nort... File src/northbridge/amd/pi/00730F01/northbridge.c:
https://review.coreboot.org/#/c/32421/1/src/northbridge/amd/pi/00730F01/nort... PS1, Line 1250: AmdGetValue(IN CONST AGESA_FIELD_NAME name, IN OUT VOID **value, IN UINT32 size) need consistent spacing around '*' (ctx:WxO)
https://review.coreboot.org/#/c/32421/1/src/northbridge/amd/pi/00730F01/nort... PS1, Line 1264: status = module_dispatch(AMD_GET_VALUE, (AMD_CONFIG_PARAMS*) &Params); "(foo*)" should be "(foo *)"