Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30775 )
Change subject: cpu/intel/car/core2: Update microcode in CAR setup
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/30775/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/30775/4//COMMIT_MSG@9
PS4, Line 9: This updates the BSP microcode during CAR setup.
Updating microcode during CAR hangs the system. […]
I just wondered if it's worth to have a conditional
path here. If we know that updating ucode in ramstage
is good enough, why not do it there? We'd not only
save some lines but also the additional CBFS walk.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30775
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8ecd1b99e18c7e73ae47f850fdc4870751dc6e8c
Gerrit-Change-Number: 30775
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Feb 2019 13:53:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment