[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Configure GPIOs again after FSP-S is done

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31250 )

Change subject: soc/intel/cannonlake: Configure GPIOs again after FSP-S is done
......................................................................

Patch Set 5:

(1 comment)

Patchset:

PS5:
> I have some insane idea \o/ My first thought was, why not set PadCfgLock, so FSP can't write the pad […]

Ugh.. I think it would be better to have FSP<->coreboot work in a more synchronized fashion than having to actively prevent what the other is doing. Locking down the padcfg will lead to other side-effects as well -- payloads, OS would run into issues trying to reconfigure pads, which won't be acceptable.

Are you seeing cases where the FSP is still configuring GPIOs it should not?