Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35849 )
Change subject: src/superio/nuvoton/nct5104d: assign IO port range to control GPIO ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
https://review.coreboot.org/c/coreboot/+/35849/1/src/superio/nuvoton/nct5104... File src/superio/nuvoton/nct5104d/superio.c:
https://review.coreboot.org/c/coreboot/+/35849/1/src/superio/nuvoton/nct5104... PS1, Line 127: reg = pnp_read_config(dev, 0x30); : pnp_write_config(dev, 0x30, reg & 0xFE); this should be a pnp_set_enable call; this duplicates functionality that could be done with a device tree setting for the WDT in the SIO in the devicetree
https://review.coreboot.org/c/coreboot/+/35849/1/src/superio/nuvoton/nct5104... PS1, Line 163: reg = pnp_read_config(dev, 0x30); : pnp_write_config(dev, 0x30, reg | 0x02); this also does what pnp_set_enable does