Attention is currently required from: Raul Rangel, Kyösti Mälkki. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43050 )
Change subject: soc/amd/common: Refactor program_gpios() for overrides ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
ping
finally got around to have a look and I like the general direction this patch, since it avoids unneeded master_switch_set/master_switch_clear sequence between each GPIO configuration in the case of gpio_configure_pads_with_override. I don't think that it solves the possible issue of a GPIO in the override being ignored when there's no corresponding base GPIO configuration. From what I remember it's mostly intended behavior, but it would be good to have at least some function that can check for this and then print some warning. This however can't be done as a part of the gpio_configure_pads_with_override call, since at least in bootblock that call is done before the console_init call. Haven't checked for the later stages.
if you're ok with that, I can take over this patch and port it forward to the current top of tree.