Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38472 )
Change subject: amd/agesa: Make BottomIo position configurable
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38472/7/src/northbridge/amd/agesa/f...
File src/northbridge/amd/agesa/family16kb/state_machine.c:
https://review.coreboot.org/c/coreboot/+/38472/7/src/northbridge/amd/agesa/f...
PS7, Line 23: MIN(0xE0,
: MAX(0x28, ((UINT16)(CONFIG_BOTTOMIO_POSITION >> 24) & 0xF8)));
It's a bit hard to read with magic numbers.
I suggest (UINT16)(MIN(0xe0000000, MAX(0x28000000, CONFIG_BOTTOMIO_POSITION)) >> 24) & 0xf8;
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38472
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie235631231bcb4aeebaff2e0026da2ea9d82f9d0
Gerrit-Change-Number: 38472
Gerrit-PatchSet: 7
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 18 Apr 2020 12:49:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment