Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38988 )
Change subject: mainboard: New ivybridge board ASUS P8Z77-M ......................................................................
Patch Set 7:
(8 comments)
https://review.coreboot.org/c/coreboot/+/38988/6/src/mainboard/asus/p8z77-m/... File src/mainboard/asus/p8z77-m/Kconfig:
PS6:
Use SPDX here as well
Done
https://review.coreboot.org/c/coreboot/+/38988/6/src/mainboard/asus/p8z77-m/... File src/mainboard/asus/p8z77-m/Kconfig.name:
PS6:
SPDX here as well (or drop the copyright notices, we don't usually have them on these files)
Done
https://review.coreboot.org/c/coreboot/+/38988/6/src/mainboard/asus/p8z77-m/... File src/mainboard/asus/p8z77-m/Makefile.inc:
PS6:
Also SPDX
Done
https://review.coreboot.org/c/coreboot/+/38988/7/src/mainboard/asus/p8z77-m/... File src/mainboard/asus/p8z77-m/acpi/superio.asl:
PS7: Maybe this should be moved to superio/nuvoton/nct6779d/acpi ?
https://review.coreboot.org/c/coreboot/+/38988/6/src/mainboard/asus/p8z77-m/... File src/mainboard/asus/p8z77-m/cmos.default:
PS6:
This should be SPDX
Done
https://review.coreboot.org/c/coreboot/+/38988/6/src/mainboard/asus/p8z77-m/... File src/mainboard/asus/p8z77-m/cmos.layout:
PS6:
SPDX here as well
Done
https://review.coreboot.org/c/coreboot/+/38988/6/src/mainboard/asus/p8z77-m/... File src/mainboard/asus/p8z77-m/devicetree.cb:
PS6:
SPDX here as well
Done
https://review.coreboot.org/c/coreboot/+/38988/6/src/mainboard/asus/p8z77-m/... File src/mainboard/asus/p8z77-m/early_init.c:
https://review.coreboot.org/c/coreboot/+/38988/6/src/mainboard/asus/p8z77-m/... PS6, Line 34: { 1, 2, 4 }, /* Port 9: USB2 internal header USB910, bottom */
Not quite in this case. The header is actually labeled USB2_910 on the PCB. […]
Sorry, I meant the "Port X" at the beginning of the comments:
{ 1, 2, 4 }, /* Port 9: USB2 internal header USB910, bottom */ { 1, 2, 6 }, /* Port 10: USB2 internal header USB1112, top */