build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44728 )
Change subject: soc/mediatek/mt8192: Do dramc digital init setting ......................................................................
Patch Set 1:
(31 comments)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_dig_config.c:
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 35: dramc_dbg("Enable DLL master slave shuffle \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 47: if (subsys->a_cfg->rank_mode==0) { spaces required around that '==' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 71: if (subsys->a_cfg->new_8x_mode==1) { spaces required around that '==' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 86: ||(subsys->dvfs_core->dq_ca_open==1)) ? 0 : 1; spaces required around that '||' (ctx:ExV)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 86: ||(subsys->dvfs_core->dq_ca_open==1)) ? 0 : 1; spaces required around that '==' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 232: u8 tx_ui = (freq_group <= DDRFREQ_400) ? 1: 0 ; spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 232: u8 tx_ui = (freq_group <= DDRFREQ_400) ? 1: 0 ; space prohibited before semicolon
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 336: dramc_dbg("[RX_INPUT][Configuration] \n"); unnecessary whitespace before a quoted newline
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 362: u8 dqsien_dqsstb_mode=0; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 372: dual_schen = (subsys->dvfs_core->dq_p2s_ratio==4) ? 0 : 1; spaces required around that '==' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 374: switch(subsys->dfs_gp->dqsien_mode) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 390: default: dramc_dbg("[DIG_SHUF_CONFIG] Unexpected subsys->dfs_gp->dqsien_mode=%1d \n", trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 390: default: dramc_dbg("[DIG_SHUF_CONFIG] Unexpected subsys->dfs_gp->dqsien_mode=%1d \n", unnecessary whitespace before a quoted newline
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 395: switch(cas_mode) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 405: default: dramc_dbg("[DIG_SHUF_CONFIG] Unexpected cas_mode(%d) input\n",cas_mode); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 405: default: dramc_dbg("[DIG_SHUF_CONFIG] Unexpected cas_mode(%d) input\n",cas_mode); trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 411: SHU_COMMON0_FREQDIV4, subsys->dvfs_core->dq_p2s_ratio==8, spaces required around that '==' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 412: SHU_COMMON0_FDIV2, subsys->dvfs_core->dq_p2s_ratio==4, spaces required around that '==' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 414: SHU_COMMON0_DM64BITEN, !(subsys->dvfs_core->dq_p2s_ratio==4)); spaces required around that '==' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 517: default:dramc_dbg("ERROR:Unexcepted subsys->dvfs_core.dq_p2s_ratio = %d\n", trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 575: u8 hwset_mr13_op_value =0; spaces required around that '=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 576: u8 hwset_vrcg_op_value =0; spaces required around that '=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 577: u8 hwset_mr2_op_value =0; spaces required around that '=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 582: ((lp4_init->work_fsp & 1) << 6) | (( 0 << 5) | 8); space prohibited after that open parenthesis '('
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 843: dramc_dbg("Enter into dvfs_pre_config\n"); Prefer using '"%s...", __func__' to using 'dvfs_pre_config', this function's name, in a string
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 909: MISC_DVFSCTL_R_DVFS_PICG_MARGIN_NEW, (ref_104m_en==1)?3:1, spaces required around that '==' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 910: MISC_DVFSCTL_R_DVFS_PICG_MARGIN2_NEW, (ref_104m_en==1)?3:1, spaces required around that '==' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 911: MISC_DVFSCTL_R_DVFS_PICG_MARGIN3_NEW, (ref_104m_en==1)?3:1); spaces required around that '==' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 925: (ref_104m_en==1) ? 6 : 4); spaces required around that '==' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 964: MISC_CG_CTRL0_RG_CG_PHY_OFF_DIABLE, !misc_cg_en, 'DIABLE' may be misspelled - perhaps 'DISABLE'?
https://review.coreboot.org/c/coreboot/+/44728/1/src/soc/mediatek/mt8192/dra... PS1, Line 1105: dramc_dbg("[RX_INPUT] configuration \n"); unnecessary whitespace before a quoted newline