Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43994 )
Change subject: soc/intel/cannonlake: Fix DMAR when no iGPU is present ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/43994/2/src/soc/intel/cannonlake/ac... File src/soc/intel/cannonlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/43994/2/src/soc/intel/cannonlake/ac... PS2, Line 297: /* Add RMRR entry */
Done
What's SDY?
https://review.coreboot.org/c/coreboot/+/43994/3/src/soc/intel/cannonlake/ac... File src/soc/intel/cannonlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/43994/3/src/soc/intel/cannonlake/ac... PS3, Line 330: igfx_dev && igfx_dev->enabled && gfxvtbar && gfxvten Instead of repeating this, put it in a variable?
const bool igfx_enabled = igfx_dev && igfx_dev->enabled && gfxvtbar && gfxvten;