[coreboot-gerrit] Change in coreboot[master]: drivers/generic/max98357a: Allow custom _HID from config

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39286 )

Change subject: drivers/generic/max98357a: Allow custom _HID from config
......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39286/11/src/drivers/generic/max983... 
File src/drivers/generic/max98357a/max98357a.c:

https://review.coreboot.org/c/coreboot/+/39286/11/src/drivers/generic/max983... 
PS11, Line 46: if (!config->hid)
             : 		acpigen_write_name_string("_HID", MAX98357A_ACPI_HID);
             : 	else
             : 		acpigen_write_name_string("_HID", config->hid);
> I had another thought... what about a "variant" option in chip.h that has enumerated values for  […]

Depending on sed capabilities in your machine you can try to search and replace using the below command:

find . -name *.cb | xargs sed -i -r 's/^([\t]+)(.*max98357a)/\1\2\n\1\tregister "hid" = "MAX98357A"/g'

I donot see a need, but if required use Static assert to ensure that all occurrences are handled.