Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41881 )
Change subject: mb/google/dedede: Switch to using auto-generated SPDs ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41881/10/src/mainboard/google/deded... File src/mainboard/google/dedede/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41881/10/src/mainboard/google/deded... PS10, Line 16: subdirs-y += spd Couple more changes: 1) GENERIC_SPD_BIN enabled in Kconfig has to be disabled. With that enabled, currently the build rules in src/lib/Makefile.inc (commit -335781ad53c) are taking effect which are pretty much the same as the build rules in spd/Makefile.inc
2) This has to be moved after the line subdirs-y += variants/$(VARIANT_DIR)/memory because the SPD_SOURCES are defined only in the other makefile. Without SPD_SOURCES getting defined, the rules to build spd.bin are not applied.