Attention is currently required from: Tarun Tuli, David Wu, Kangheui Won, Reka Norman, Tyler Wang, Nick Vaccaro, Eric Lai.
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69693 )
Change subject: mb/google/brya/var/craask: Modify GPIOs for craaskneto/craaskino
......................................................................
Patch Set 7:
(5 comments)
File src/mainboard/google/brya/variants/craask/fw_config.c:
https://review.coreboot.org/c/coreboot/+/69693/comment/1ef06cfc_acefd6d5
PS6, Line 20: _extern
`_extend` to be consistent with gpio. […]
fixed
https://review.coreboot.org/c/coreboot/+/69693/comment/38333f7c_369338ea
PS6, Line 67: /* craask: board id = 0x00 ~ 0x1f */
code indent should use tabs where possible […]
fix
https://review.coreboot.org/c/coreboot/+/69693/comment/2a08d931_96b47c31
PS6, Line 68: if (id < 0x20) {
Since the LTE pads are the only ones that differ, can you put the if statement around the LTE block […]
fix.
https://review.coreboot.org/c/coreboot/+/69693/comment/8b8555b8_1a5284b6
PS6, Line 95: /* craaskneto/craaskino: board id >= 0x20 */
code indent should use tabs where possible […]
fixed
https://review.coreboot.org/c/coreboot/+/69693/comment/fbb5ee29_34435c9e
PS6, Line 103: gpio_padbased_override(padbased_table, wfc_disable_pads,
For (id < 0x20), they're only disabled if the fw_config is not set, so I think we still need it in f […]
fixed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69693
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b9c90abe562768ea2afff5608a8cfac764569d5
Gerrit-Change-Number: 69693
Gerrit-PatchSet: 7
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 23 Nov 2022 04:00:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment