Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40721 )
Change subject: nb/intel/sandybridge/raminit: Fix ECC scrub ......................................................................
Patch Set 2: Code-Review+2
(4 comments)
https://review.coreboot.org/c/coreboot/+/40721/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40721/2//COMMIT_MSG@19 PS2, Line 19: XeonE3 Space? Xeon E3
https://review.coreboot.org/c/coreboot/+/40721/2//COMMIT_MSG@19 PS2, Line 19: HPZ220 Add a space? HP Z220
https://review.coreboot.org/c/coreboot/+/40721/2/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/40721/2/src/northbridge/intel/sandy... PS2, Line 2974: for (bank = 0; bank < 8; bank ++) {
space prohibited before that '++' (ctx:WxB)
Should be addressed
https://review.coreboot.org/c/coreboot/+/40721/2/src/northbridge/intel/sandy... PS2, Line 2976: This is getting rather squished against the right margin... I'll factor it out in a follow-up