Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30942 )
Change subject: mainboard/samsung/350v5c: add initial board files ......................................................................
Patch Set 1:
(14 comments)
Details gathered from this laptop:
- It has switchable graphics with Intel/AMD - It has an ENE KB9012 EC - It has 4+2MB flash chips (6144KB option not yet in coreboot Kconfig)
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/Kconfig File src/mainboard/samsung/350v5c/Kconfig:
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/Kconfig... PS1, Line 5: BOARD_ROMSIZE_KB_6144 This does not exist and has to be added.
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/Kconfig... PS1, Line 12: SANDYBRIDGE_IVYBRIDGE_LVDS Replace with GFX_GMA_INTERNAL_IS_LVDS
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/Kconfig... PS1, Line 42: # FIXME: check this I confirm it is correct. If you are curious, this is the DRAMRST_CNTRL_PCH wire on LA-8862P schematics.
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/Makefil... File src/mainboard/samsung/350v5c/Makefile.inc:
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/Makefil... PS1, Line 2: ramstage-y += gnvs.c Move this file to acpi_tables.c and remove this line.
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/board_i... File src/mainboard/samsung/350v5c/board_info.txt:
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/board_i... PS1, Line 3: Flashrom support: n If internal flashing works, this can be set to y
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/board_i... PS1, Line 4: FIXME: put ROM package, ROM socketed, Release year You can check other mainboards to see which information you should add.
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/devicet... File src/mainboard/samsung/350v5c/devicetree.cb:
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/devicet... PS1, Line 1: # FIXME: check gfx.ndid and gfx.did : register "gfx.did" = "{ 0x80000100, 0x80000240, 0x80000410, 0x80000410, 0x00000005 }" : register "gfx.link_frequency_270_mhz" = "0" : register "gfx.ndid" = "3" : register "gfx.use_spread_spectrum_clock" = "0" : register "gpu_cpu_backlight" = "0x00000000" : register "gpu_dp_b_hotplug" = "0" : register "gpu_dp_c_hotplug" = "0" : register "gpu_dp_d_hotplug" = "0" : register "gpu_panel_port_select" = "0" : register "gpu_panel_power_backlight_off_delay" = "0" : register "gpu_panel_power_backlight_on_delay" = "0" : register "gpu_panel_power_cycle_delay" = "0" : register "gpu_panel_power_down_delay" = "0" : register "gpu_panel_power_up_delay" = "0" : register "gpu_pch_backlight" = "0x00000000" You may need to re-run autoport with the iGPU enabled to make sure these values are correct.
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/devicet... PS1, Line 33: : Remove all "subsystemid" entries after this point, and add this here:
subsystemid 0x144d 0xc0d8 inherit
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/devicet... PS1, Line 39: register "gen3_dec" = "0x00000000" : register "gen4_dec" = "0x00000000" Can be removed.
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/devicet... PS1, Line 108: : device pci 00.0 on # Host bridge Host bridge : subsystemid 0x144d 0xc0d8 : end : device pci 01.0 on # PCIe Bridge for discrete graphics : subsystemid 0x144d 0xc0d8 : end : device pci 02.0 on # Internal graphics VGA controller : subsystemid 0x144d 0xc0d8 : end Please move above the "chip southbridge" line.
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/mainboa... File src/mainboard/samsung/350v5c/mainboard.c:
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/mainboa... PS1, Line 11: { if (0) {
For now, it is probably unneeded.
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/mainboa... PS1, Line 45: install_intel_vga_int15_handler(GMA_INT15_ACTIVE_LFP_INT_LVDS, GMA_INT15_PANEL_FIT_DEFAULT, GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
line over 80 characters
Check how other mainboards split this line to fit into the 80-char limit.
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/romstag... File src/mainboard/samsung/350v5c/romstage.c:
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/romstag... PS1, Line 29: #include "northbridge/intel/sandybridge/sandybridge.h" : #include "northbridge/intel/sandybridge/raminit_native.h" : #include "southbridge/intel/bd82x6x/pch.h" Please replace the "double quotes" with <angle brackets>.
https://review.coreboot.org/#/c/30942/1/src/mainboard/samsung/350v5c/romstag... PS1, Line 78: read_spd(&spd[0], 0x50, id_only); : read_spd(&spd[1], 0x51, id_only); : read_spd(&spd[2], 0x52, id_only); : read_spd(&spd[3], 0x53, id_only); These entries correspond to slots on the mainboard. There should be one line per RAM slot.