[coreboot-gerrit] Change in coreboot[master]: superio/common: Validate devicetree

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38863 )

Change subject: superio/common: Validate devicetree
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38863/2/src/superio/common/ssdt.c 
File src/superio/common/ssdt.c:

https://review.coreboot.org/c/coreboot/+/38863/2/src/superio/common/ssdt.c@1... 
PS2, Line 167: const u8 ldn = dev->path.pnp.device & 0xff;
             : 	const u8 vldn = (dev->path.pnp.device >> 8) & 0x7;
> And I guess that running the SSDT generator would not be possible, so an early return would be neede […]

Done

https://review.coreboot.org/c/coreboot/+/38863/2/src/superio/common/ssdt.c@1... 
PS2, Line 184: BIOS_CRIT
> If it's a critical bug, shouldn't we return instead of trying to generate the SSDT?

Done