Attention is currently required from: Marc Jones, Martin Roth, Stefan Reinauer, Kyösti Mälkki, Patrick Rudolph.
Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49492 )
Change subject: soc/intel/baytrail: Drop runtime ACPI mode change via SMI
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I cannot access the original text of BUG=chrome-os-partner:30836 […]
I don't have access to that chromeos bug either. Again what the concerns is break some functionality in master branch even baytrail support had not been dropped by coreboot.
If current seabios do not need the pci mode any more, then that's also okay for me. We need to cover the changes in depthcharge as well. Or at least mask that with config.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49492
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I76736fa72af30003d86dfc2551b673037c1dd522
Gerrit-Change-Number: 49492
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
reinauer@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Stefan Reinauer
reinauer@chromium.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 25 Jan 2021 05:10:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lance Zhao
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment