Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32339 )
Change subject: mediatek/mt8183: Enable RTC eosc calibration feature to save power ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/#/c/32339/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32339/1//COMMIT_MSG@9 PS1, Line 9: shutdown shuts down
Do you mean a real shutdown? Why does it matter, how the RTC is configure there?
https://review.coreboot.org/#/c/32339/1//COMMIT_MSG@9 PS1, Line 9: When system shutdown, RTC enable eosc calibration feature to save : power. … This will reduce the RTC clock source accuracy. ?
https://review.coreboot.org/#/c/32339/1//COMMIT_MSG@11 PS1, Line 11: boot up boot
https://review.coreboot.org/#/c/32339/1//COMMIT_MSG@11 PS1, Line 11: a more accurate one Which one?
https://review.coreboot.org/#/c/32339/1//COMMIT_MSG@12 PS1, Line 12: How much power is saved?