Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33624 )
Change subject: soc/amd/stoneyridge: Change code to accommodate Merlin Falcon SOC
......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/coreboot/+/33624/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/33624/9//COMMIT_MSG@9
PS9, Line 9: carrizo CPU in a SOC presentation
Ok, will do.
Done
https://review.coreboot.org/c/coreboot/+/33624/9//COMMIT_MSG@12
PS9, Line 12: merlinfalcon
I was not sure if Merlin Falcon was a single word or 2 words (which looks better). Will do.
Done
https://review.coreboot.org/c/coreboot/+/33624/9/src/soc/amd/stoneyridge/chi...
File src/soc/amd/stoneyridge/chip.h:
https://review.coreboot.org/c/coreboot/+/33624/9/src/soc/amd/stoneyridge/chi...
PS9, Line 29: MAX_DIMMS_PER_CH
You are correct, there's some confusion on the BKDG talking about 4 DIMM, but when you get the detai […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33624
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00fe832324500bcb07fca292a0a55f7258a2d82f
Gerrit-Change-Number: 33624
Gerrit-PatchSet: 14
Gerrit-Owner: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: Charles Marslett
charles.marslett@silverbackltd.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 22 Jul 2019 21:06:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-MessageType: comment