[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Add code for early tcss

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42079 )

Change subject: soc/intel/tigerlake: Add code for early tcss
......................................................................

Patch Set 27:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42079/27/src/soc/intel/tigerlake/fs... 
File src/soc/intel/tigerlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/42079/27/src/soc/intel/tigerlake/fs... 
PS27, Line 390: if (CONFIG(EARLY_TCSS) && (vboot_recovery_mode_enabled() ||
              : 			vboot_developer_mode_enabled()))
              : 			mainboard_early_tcss_enable();
> I will look into making a patch on top of this one that addresses these concerns. […]

Understood. Apologize for the long review cycle here. I think it's okay if you want to do this in a follow-up change. I would highly recommend updating the commit message and Kconfig to make it clear that this is only for performing graphics initialization for external monitors over Type-C. Currently, the way it is written, it seems to indicate that early TCSS configuration is done for external monitors as well as other devices over type-C.