1 comment:
File src/soc/intel/tigerlake/fsp_params.c:
if (CONFIG(EARLY_TCSS) && (vboot_recovery_mode_enabled() ||
vboot_developer_mode_enabled()))
mainboard_early_tcss_enable();
I will look into making a patch on top of this one that addresses these concerns. […]
Understood. Apologize for the long review cycle here. I think it's okay if you want to do this in a follow-up change. I would highly recommend updating the commit message and Kconfig to make it clear that this is only for performing graphics initialization for external monitors over Type-C. Currently, the way it is written, it seems to indicate that early TCSS configuration is done for external monitors as well as other devices over type-C.
To view, visit change 42079. To unsubscribe, or for help writing mail filters, visit settings.