Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31122 )
Change subject: selfload: check target memory type in selfload_check ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/31122/4/src/include/bootmem.h File src/include/bootmem.h:
https://review.coreboot.org/#/c/31122/4/src/include/bootmem.h@100 PS4, Line 100: bootmem_region_targets_ram Should probably rename this to bootmem_region_targets_type()
https://review.coreboot.org/#/c/31122/4/src/lib/selfboot.c File src/lib/selfboot.c:
https://review.coreboot.org/#/c/31122/4/src/lib/selfboot.c@49 PS4, Line 49: segment_targets_usable_ram Should also be renamed (e.g. segment_targets_type()).
https://review.coreboot.org/#/c/31122/4/src/lib/selfboot.c@251 PS4, Line 251: enum bootmem_type dest_type If you want to treat the checker_t argument as a void*, you should do that here already (or don't do it at all).