Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31323 )
Change subject: mb/asus/p5ql-em: Add mainboard ......................................................................
Patch Set 8:
(10 comments)
https://review.coreboot.org/c/coreboot/+/31323/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/31323/2//COMMIT_MSG@15 PS2, Line 15: macaddress
MAC address
Done
https://review.coreboot.org/c/coreboot/+/31323/6/src/mainboard/asus/p5qc/rom... File src/mainboard/asus/p5qc/romstage.c:
https://review.coreboot.org/c/coreboot/+/31323/6/src/mainboard/asus/p5qc/rom... PS6, Line 31: /* Early mainboard specific GPIO setup. : * We should use standard gpio.h eventually : */
??
Done
https://review.coreboot.org/c/coreboot/+/31323/1/src/mainboard/asus/p5ql-em/... File src/mainboard/asus/p5ql-em/Kconfig:
https://review.coreboot.org/c/coreboot/+/31323/1/src/mainboard/asus/p5ql-em/... PS1, Line 41:
Name is "P5QL-EM" according to Asus (also check Kconfig. […]
Done
https://review.coreboot.org/c/coreboot/+/31323/4/src/mainboard/asus/p5ql-em/... File src/mainboard/asus/p5ql-em/board_info.txt:
https://review.coreboot.org/c/coreboot/+/31323/4/src/mainboard/asus/p5ql-em/... PS4, Line 2: P5QC
Seems wrong?
Done
https://review.coreboot.org/c/coreboot/+/31323/1/src/mainboard/asus/p5ql-em/... File src/mainboard/asus/p5ql-em/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/31323/1/src/mainboard/asus/p5ql-em/... PS1, Line 73: device pci 1c.1 off end # PCIe 2 : device pci 1c.2 off end # PCIe 3
One of these should be the other PCIe x1 slot I guess
possibly. I can't test for now.
https://review.coreboot.org/c/coreboot/+/31323/1/src/mainboard/asus/p5ql-em/... PS1, Line 163: device pci 1f.5 on # IDE
right. I wrongly thought this would be the IDE slot, but ich10 does not support that anymore.
Done
https://review.coreboot.org/c/coreboot/+/31323/5/src/mainboard/asus/p5ql-em/... File src/mainboard/asus/p5ql-em/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/31323/5/src/mainboard/asus/p5ql-em/... PS5, Line 162: device pci 1f.4 off end
What's this device?
Performance counters I think. It's the must set to 1 bit.
https://review.coreboot.org/c/coreboot/+/31323/1/src/mainboard/asus/p5ql-em/... File src/mainboard/asus/p5ql-em/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/31323/1/src/mainboard/asus/p5ql-em/... PS1, Line 33: Scope (_SB) { : Device (PCI0)
Device (_SB. […]
Done
https://review.coreboot.org/c/coreboot/+/31323/4/src/mainboard/asus/p5ql-em/... File src/mainboard/asus/p5ql-em/romstage.c:
https://review.coreboot.org/c/coreboot/+/31323/4/src/mainboard/asus/p5ql-em/... PS4, Line 135: /* TODO: FSB BSEL pins... */
Seems to be done above?
Done
https://review.coreboot.org/c/coreboot/+/31323/4/src/mainboard/asus/p5ql-em/... PS4, Line 135: /* TODO: FSB BSEL pins... */
Seems to be done above?
Done