Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32533 )
Change subject: sb/i82801gx/watchdog: Use {read,write}_pmbase function
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32533/1/src/southbridge/intel/i82801gx/watch...
File src/southbridge/intel/i82801gx/watchdog.c:
https://review.coreboot.org/#/c/32533/1/src/southbridge/intel/i82801gx/watch...
PS1, Line 46: write_pmbase16(TCO1_CNT + 0x04, (1 << 3));
: write_pmbase16(TCO1_CNT + 0x06, (1 << 2));
:
TCO1_CNT is 0x68, not 0x60. so these are off by 8
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32533
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I704780b6ae7238560dcb72fc027addc1089e0674
Gerrit-Change-Number: 32533
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Wed, 01 May 2019 16:06:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment