Attention is currently required from: Eran Mitrani, Kapil Porwal, Tarun.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78649?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/rex: Enable sending EOP from payload ......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/rex/Kconfig:
https://review.coreboot.org/c/coreboot/+/78649/comment/a73c87b2_270145b7 : PS4, Line 31: select SOC_INTEL_CSE_SEND_EOP_BY_PAYLOAD Instead of making this a select, could we enable it as a default instead? There are a lot of "depends on" statements in this option, and a select will override all of them and just force it to be enabled, even if the requirements are not met.
Additionally, we'd like to be able to support a non-chromeos build that doesn't use depthcharge, and still support sending the EOP.
You'd want something like this down in the main section protected by `if BOARD_GOOGLE_REX_COMMON`
``` config SOC_INTEL_CSE_SEND_EOP_BY_PAYLOAD prompt "Send End of Post message in the payload" default y if CHROMEOS
config SOC_INTEL_CSE_SEND_EOP_ASYNC default y if !SOC_INTEL_CSE_SEND_EOP_BY_PAYLOAD ```