Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48660 )
Change subject: soc/intel/xeon_sp: Fix compiling with CONFIG_DEBUG_RESOURCES
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48660/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48660/1//COMMIT_MSG@7
PS1, Line 7: soc/intel/xeon_sp: Fix compiling with CONFIG_DEBUG_RESOURCES
Please add a config to build-test the code with this option. I usually select multiple options to improve coverage. Some example changes I've done: CB:43977 CB:45974 CB:48546
Done in https://review.coreboot.org/c/coreboot/+/48675
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48660
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42ddea2c04bf1ecb2466db3d56d15d51bda486c8
Gerrit-Change-Number: 48660
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 16 Dec 2020 21:07:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment