[coreboot-gerrit] Change in coreboot[master]: soc/amd/cezanne: Add uart controllers to chipset.cb

[Furquan Shaikh (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Ivy Jian, Felix Held.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52287 )

Change subject: soc/amd/cezanne: Add uart controllers to chipset.cb
......................................................................

Patch Set 1: Code-Review+1

(2 comments)

Patchset:

PS1: 
LGTM. But let's wait for resolution on the default state comment.

File src/soc/amd/cezanne/chipset.cb:

https://review.coreboot.org/c/coreboot/+/52287/comment/b9c81fcd_27e39b8f 
PS1, Line 110: off
> I would rather leave these on by default. […]

The chipset tree typically sets the default as "off" for devices that are not necessarily required for all platforms using this SoC. It gives the mainboard a chance to explicitly select what it is using/designed for. In my opinion, keeping this as "off" is fine and also keeps it consistent with other interfaces - i2c, usb, etc.